Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix RegExp #3009

Merged
merged 1 commit into from
Feb 12, 2021
Merged

test: fix RegExp #3009

merged 1 commit into from
Feb 12, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

already present

Motivation / Use-Case

fix snapshot issue

Breaking Changes

None

Additional Info

@snitin315 snitin315 marked this pull request as draft February 12, 2021 12:22
alexander-akait
alexander-akait reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it will fix the problem with CI

@codecov
Copy link

codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #3009 (1852ba2) into master (b0868c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3009   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files          37       37           
  Lines        1262     1262           
  Branches      326      326           
=======================================
  Hits         1166     1166           
  Misses         91       91           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0868c3...9a67bbc. Read the comment docs.

@alexander-akait
Copy link
Member

macos is very slow 😞

@snitin315 snitin315 marked this pull request as ready for review February 12, 2021 13:03
@snitin315
Copy link
Member Author

All green 💯

@alexander-akait alexander-akait merged commit ad6619b into webpack:master Feb 12, 2021
@alexander-akait
Copy link
Member

Thanks

@snitin315 snitin315 deleted the test/snapshot branch February 12, 2021 13:31
@snitin315
Copy link
Member Author

@alexander-akait can you share the roadmap ?

@alexander-akait
Copy link
Member

alexander-akait commented Feb 12, 2021 •
edited
Loading

@snitin315 I don't have strong roadmap right now, but I can do it tomorrow, right now we need fix it #2920, PR is solve the problem (so no need to write something), but we need rewrite test, I can give invite your and can can finish tests in my PR, thanks again

@snitin315
Copy link
Member Author

Sounds good 👍🏻 . Please send the invite.

@alexander-akait
Copy link
Member

You are part of webpack-dev-server and webpack-dev-middleware repos, so you can finish my PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@hiroppy hiroppy Awaiting requested review from hiroppy hiroppy is a code owner

@knagaitsev knagaitsev Awaiting requested review from knagaitsev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snitin315 @alexander-akait